Skip to content

Fix MSVC compilation issues on Windows (M_PI, typeof) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pansuestc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix MSVC compilation issues on Windows (M_PI, typeof) #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Bembel/src/util/Constants.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This file is part of Bembel, the higher order C++ boundary element library.
// This file is part of Bembel, the higher order C++ boundary element library.
//
// Copyright (C) 2022 see <http://www.bembel.eu>
//
Expand All @@ -11,6 +11,10 @@
#ifndef BEMBEL_SRC_UTIL_CONSTANTS_HPP_
#define BEMBEL_SRC_UTIL_CONSTANTS_HPP_

#ifndef M_PI
// since M_PI is not defined in Windows MSVC++
#define M_PI 3.14159265358979323846
#endif
namespace Bembel {
namespace Constants {

Expand Down
4 changes: 2 additions & 2 deletions examples/HelmholtzAdjointDoubleLayerH2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This file is part of Bembel, the higher order C++ boundary element library.
// This file is part of Bembel, the higher order C++ boundary element library.
//
// Copyright (C) 2024 see <http://www.bembel.eu>
//
Expand Down Expand Up @@ -94,7 +94,7 @@ int main() {
auto system_matrix = -0.5 * M + AK; // important: do NOT change auto!

// solve system
GMRES<typeof(system_matrix), IdentityPreconditioner> gmres;
GMRES<decltype(system_matrix), IdentityPreconditioner> gmres;
gmres.compute(system_matrix);
VectorXcd rho = gmres.solve(disc_lf.get_discrete_linear_form());

Expand Down
4 changes: 2 additions & 2 deletions examples/HelmholtzDoubleLayerH2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This file is part of Bembel, the higher order C++ boundary element library.
// This file is part of Bembel, the higher order C++ boundary element library.
//
// Copyright (C) 2024 see <http://www.bembel.eu>
//
Expand Down Expand Up @@ -90,7 +90,7 @@ int main() {
auto system_matrix = 0.5 * M + K; // important: do NOT change auto!

// solve system
GMRES<typeof(system_matrix), IdentityPreconditioner> gmres;
GMRES<decltype(system_matrix), IdentityPreconditioner> gmres;
gmres.compute(system_matrix);
VectorXcd rho = gmres.solve(disc_lf.get_discrete_linear_form());

Expand Down
4 changes: 2 additions & 2 deletions examples/LaplaceAdjointDoubleLayerH2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This file is part of Bembel, the higher order C++ boundary element library.
// This file is part of Bembel, the higher order C++ boundary element library.
//
// Copyright (C) 2024 see <http://www.bembel.eu>
//
Expand Down Expand Up @@ -90,7 +90,7 @@ int main() {
auto system_matrix = 0.5 * M + AK; // important: do NOT change auto!

// solve system
GMRES<typeof(system_matrix), IdentityPreconditioner> gmres;
GMRES<decltype(system_matrix), IdentityPreconditioner> gmres;
gmres.compute(system_matrix);
VectorXd rho = gmres.solve(disc_lf.get_discrete_linear_form());

Expand Down
4 changes: 2 additions & 2 deletions examples/LaplaceDoubleLayerH2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// This file is part of Bembel, the higher order C++ boundary element library.
// This file is part of Bembel, the higher order C++ boundary element library.
//
// Copyright (C) 2024 see <http://www.bembel.eu>
//
Expand Down Expand Up @@ -87,7 +87,7 @@ int main() {
auto system_matrix = -0.5 * M + K; // important: do NOT change auto!

// solve system
GMRES<typeof(system_matrix), IdentityPreconditioner> gmres;
GMRES<decltype(system_matrix), IdentityPreconditioner> gmres;
gmres.compute(system_matrix);
VectorXd rho = gmres.solve(disc_lf.get_discrete_linear_form());

Expand Down