Fix MSVC compilation issues on Windows (M_PI, typeof) #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two compilation errors encountered when building the project on Windows using the MSVC compiler.
M_PIUndeclared IdentifierM_PIis not automatically defined in<cmath>or<math.h>. It often requires a specific macro like_USE_MATH_DEFINESto be set before including these headers.#ifndef M_PIguard with a standard definition of PI insrc/util/Constants.hpp. This ensuresM_PIis available even if the compiler settings don't provide it.typeofIdentifier Not Foundtypeofis a non-standard language extension, typically supported by GCC and Clang. It is not a standard C++ keyword and is not recognized by MSVC.typeofwith the standard C++11 keyworddecltypeinexamples/LaplaceAdjointDoubleLayerH2.cpp.decltype(expr)is the standard way to obtain the type of an expression.Verification:
These changes have been tested and successfully resolve the compilation errors on Windows using Visual Studio 2022 (MSVC).