Skip to content

fix: compat with old numpy #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jokasimr wants to merge 1 commit into from
Closed

fix: compat with old numpy #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ess/beer/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
def _rotation_from_y_rotation_matrix(rot):
'''Assuming the rotation is around the y-axis
this function creates a rotation operator from the rotation matrix.'''
angle = np.atan2(rot[2, 0], rot[0, 0])
# Numpy backwards compatibility.
atan2 = np.atan2 if hasattr(np, 'atan2') else np.arctan2
angle = atan2(rot[2, 0], rot[0, 0])
return sc.spatial.rotation(
value=[
0.0,
Expand Down
Loading