Skip to content

Conversation

@jokasimr
Copy link
Contributor

Fixes the nightly lower bound tests.

@jokasimr jokasimr mentioned this pull request Jan 26, 2026
@jl-wynen
Copy link
Member

Scipp requires numpy >=2. So there is no need to try and support anything older here. I am surprised this works at all in CI. But I am not confident that the C++ bindings can fully support numpy 1.

@jokasimr
Copy link
Contributor Author

Oh I see, good to know

@jokasimr jokasimr closed this Jan 26, 2026
@jokasimr
Copy link
Contributor Author

jokasimr commented Jan 26, 2026

Scipp requires numpy >=2.

I'm surprised the pin in scipp does not make the environment resolve to numpy>=2.0 automatically.

@jl-wynen
Copy link
Member

Scipp requires numpy >=2.

I'm surprised the pin in scipp does not make the environment resolve to numpy>=2.0 automatically.

That happens because we use --resolution=lowest-direct, not lowest.

@jokasimr
Copy link
Contributor Author

That happens because we use --resolution=lowest-direct, not lowest.

👍 Should we change it?

@jl-wynen
Copy link
Member

I don't think so. The tests are meant to check the package itself, not its dependencies. And packages should not rely on transitive dependencies

@jokasimr
Copy link
Contributor Author

That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants