Skip to content

fix: prevent duplicate disable action when extension is disabled globally #289324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prathamanvekar wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

fix: prevent duplicate disable action when extension is disabled globally #289324

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f233e4
fix: prevent duplicate disable action when extension is disabled glob…
prathamanvekar Jan 21, 2026
ac689dd
test: verify disable action is hidden when globally disabled
prathamanvekar Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,7 +1752,8 @@ export class DisableGloballyAction extends ExtensionAction {
if (this.extension && this.extension.local && !this.extension.isWorkspaceScoped && this.extensionService.extensions.some(e => areSameExtensions({ id: e.identifier.value, uuid: e.uuid }, this.extension!.identifier))) {
this.enabled = this.extension.state === ExtensionState.Installed
&& (this.extension.enablementState === EnablementState.EnabledGlobally || this.extension.enablementState === EnablementState.EnabledWorkspace)
&& this.extensionEnablementService.canChangeEnablement(this.extension.local);
&& this.extensionEnablementService.canChangeEnablement(this.extension.local)
&& !this.extensionEnablementService.isDisabledGlobally(this.extension.local);
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test case to verify that DisableGloballyAction is disabled when an extension is disabled globally but enabled for the workspace. This would cover the specific scenario fixed by this PR. The test file at src/vs/workbench/contrib/extensions/test/electron-browser/extensionsActions.test.ts has tests for other scenarios but not this one.

Copilot uses AI. Check for mistakes.
Copy link
Author

@prathamanvekar prathamanvekar Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the requested unit test case to verify the fix.

}
}

Expand Down
Loading