fix: prevent duplicate disable action when extension is disabled globally #289324
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the "Disable" action incorrectly appeared in the extension dropdown menu when an extension was already disabled globally but enabled for the current workspace, resulting in both "Disable" and "Disable (Workspace)" appearing simultaneously.
Changes:
- Added a check to
DisableGloballyAction.update()to hide the action when the extension is already globally disabled
| && (this.extension.enablementState === EnablementState.EnabledGlobally || this.extension.enablementState === EnablementState.EnabledWorkspace) | ||
| && this.extensionEnablementService.canChangeEnablement(this.extension.local); | ||
| && this.extensionEnablementService.canChangeEnablement(this.extension.local) | ||
| && !this.extensionEnablementService.isDisabledGlobally(this.extension.local); |
There was a problem hiding this comment.
Consider adding a test case to verify that DisableGloballyAction is disabled when an extension is disabled globally but enabled for the workspace. This would cover the specific scenario fixed by this PR. The test file at src/vs/workbench/contrib/extensions/test/electron-browser/extensionsActions.test.ts has tests for other scenarios but not this one.
There was a problem hiding this comment.
Added the requested unit test case to verify the fix.
|
@microsoft-github-policy-service agree |
2 participants
Fixes #244138
Description
The "Disable" button was incorrectly appearing in the extension dropdown menu even when the extension was already disabled globally (but enabled for the current workspace). This resulted in both "Disable" and "Disable (Workspace)" appearing simultaneously, which is redundant.
This fix adds a check to
DisableGloballyAction.update()to ensure the global "Disable" action is hidden if the extension is already globally disabled.Testing
Screenshots
Before:
After:
