-
Notifications
You must be signed in to change notification settings - Fork 14
[DO NOT MERGE] change: extend tenant settings #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ma attributes in powerplatform_tenant_settings
…d product feedback settings - Removed `disable_nps_comments_reachout` and `disable_survey_feedback` from TenantSettingsDataSourceModel and TenantSettingsResourceModel. - Added `product_feedback` nested attribute in PowerPlatformSettingsModel with fields to control feedback settings. - Introduced `ProductFeedbackSettings` struct to encapsulate feedback-related configurations. - Updated resource schema to reflect changes in tenant settings. - Modified tests to validate the new product feedback settings and removed references to deprecated fields.
…ture - Added new properties to powerAutomate and powerApps sections in multiple JSON files. - Updated existing properties to maintain consistency across tenant settings. - Ensured all JSON files are formatted correctly and adhere to the latest schema requirements.
…tting to tenant settings
…s setting to tenant settings
…and adjust publishing settings
… and update related tests
…form API and add new settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request extends the Power Platform tenant settings resource and data source to better align attribute names with the Power Platform API while introducing new configuration options.
Changes:
- Renamed multiple tenant settings attributes to align with the Power Platform API naming conventions
- Added new tenant settings attributes for product feedback, copilot, governance, licensing, and intelligence
- Deprecated
disable_create_from_imageanddisable_create_from_figmaattributes
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| resource_tenant_settings.go | Updated schema with new/renamed attributes and deprecation markers |
| datasource_tenant_settings.go | Updated data source schema to match resource changes |
| models.go | Updated model structures to support new attributes |
| dto.go | Added DTO structures and conversion logic for new attributes |
| resource_tenant_settings_test.go | Updated tests to cover new and renamed attributes |
| datasource_tenant_settings_test.go | Updated data source tests |
| api_tenant_settings.go | Added correction logic for new UUID field |
| JSON test fixtures | Updated all test fixtures with new API response structure |
| examples/resource.tf | Updated example configuration with new attributes |
| docs/* | Updated documentation for resource and data source |
| .changes/* | Added changelog entries for deprecations and changes |
internal/services/tenant_settings/resource_tenant_settings_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…_copilot_help_assistance' in tenant settings
….com/microsoft/terraform-provider-power-platform into mawasile/959-missing-tenant-settings
…vironment_admins' in tenant settings
| - `policy` (Attributes) Policy (see [below for nested schema](#nestedatt--power_platform--governance--policy)) | ||
| - `weekly_digest_email_recipients` (Set of String) Weekly Digest Email Recipients | ||
|
|
||
| <a id="nestedatt--power_platform--governance--policy"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding a section for current users to migrate to this version, such as deprecated fields, moved fields, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would require creating custom markdown page, maybe we can mention that in release notes?
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Co-authored-by: Engin Polat <118744+polatengin@users.noreply.github.com>
…PI and update documentation
….com/microsoft/terraform-provider-power-platform into mawasile/959-missing-tenant-settings
…gement strategies
….com/microsoft/terraform-provider-power-platform into mawasile/959-missing-tenant-settings
This pull request makes significant updates to the Power Platform tenant settings resource and data source to better align attribute names with the Power Platform API, introduces several new configuration options, and deprecates some existing attributes. The documentation and example usage files have been updated accordingly.
The most important changes are:
Breaking/Renaming Changes:
disable_survey_feedbackis nowproduct_feedback.disable_user_survey_feedback, and several other attributes have been similarly renamed or moved under new nested blocks.New Features and Attributes:
product_feedback.disable_attachmentsproduct_feedback.disable_microsoft_surveys_sendpower_apps.disable_copilotpower_apps.enable_canvas_app_insightspower_automate.allow_use_of_hosted_browsergovernance.weekly_digest_email_recipientslicensing.apply_auto_claim_power_automate_to_only_managed_environmentsintelligence.copilot_studio_authors_security_group_idenable_support_use_bing_search_solutions[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]
Deprecations:
disable_create_from_imageanddisable_create_from_figmaattributes in both the data source and resource. These are now marked as deprecated in documentation and should be replaced with updated configuration. [1] [2] [3]Documentation Updates:
docs/data-sources/tenant_settings.mdanddocs/resources/tenant_settings.mdto reflect all attribute renames, deprecations, and new options, including new nested blocks and improved descriptions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Example Updates:
examples/resources/powerplatform_tenant_settings/resource.tfto use the new attribute names and structures, and to demonstrate new features. [1] [2]These changes improve alignment with the Power Platform API, add new configuration flexibility, and clarify the documentation for users.