Support testing for private/custom models hosted on GCP #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Test Results 6 files 6 suites 21m 43s ⏱️ Results for commit 17156e8. |
klemen1999
approved these changes
Jan 5, 2026
Collaborator
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge once tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test remotely-stored models that came from posted issues. They are uploaded on GCS buckets and more can be added over time.
Added v12 (yolov12) to the "choices" in the
--yolo-versionargument because I had forgotten to do that in the Yolov12 PR.Specification
Right now there are three uploaded and tested models:
yolov7-custom.pt(fine-tuned YoloV7 instead of just pre-trained), YOLOv6nNORO.pt (from #73), and yolov8-grayscale.pt (from #77).Dependencies & Potential Impact
The CI step that involves downloading weights and running these specific tests is only run if the PR is opened through this repository and not a fork. For now, for security reasons let's have it like this and we can run these specific remote tests manually if someone contributes through community forks and we think it might break something.
Deployment Plan
Testing & Validation
Tested locally by authenticating to
gcloudand running the following command:pytest tests/test_end2end.py::test_private_model_conversion --test-private -s -v