Skip to content

Conversation

@sensei-hacker
Copy link
Member

@sensei-hacker sensei-hacker commented Jan 22, 2026

User description

Testing a new Github action


PR Type

Enhancement


Description

  • Remove unused invertedCardDetection setting from blackbox configuration

  • Delete related documentation and YAML configuration entries

  • Simplify blackbox struct by removing obsolete card detection field


Diagram Walkthrough

flowchart LR
  A["blackboxConfig struct"] -->|remove field| B["invertedCardDetection removed"]
  C["settings.yaml"] -->|remove entry| D["sdcard_detect_inverted deleted"]
  E["Settings.md docs"] -->|remove section| F["Documentation cleaned up"]
Loading

File Walkthrough

Relevant files
Enhancement
blackbox.c
Remove invertedCardDetection initialization                           

src/main/blackbox/blackbox.c

  • Remove invertedCardDetection field initialization from
    PG_RESET_TEMPLATE macro
  • Simplify blackbox configuration structure initialization
+0/-1     
blackbox.h
Remove invertedCardDetection struct field                               

src/main/blackbox/blackbox.h

  • Remove uint8_t invertedCardDetection field from blackboxConfig_s
    typedef
  • Reduce struct size by eliminating unused configuration field
+0/-1     
Configuration changes
settings.yaml
Remove sdcard_detect_inverted YAML entry                                 

src/main/fc/settings.yaml

  • Remove sdcard_detect_inverted setting entry from blackbox
    configuration group
  • Delete associated description, default value, and condition clauses
  • Remove bool type definition for the setting
+0/-6     
Documentation
Settings.md
Remove sdcard_detect_inverted documentation                           

docs/Settings.md

  • Remove entire sdcard_detect_inverted documentation section
  • Delete explanation about SD card detection behavior and hardware
    variants
  • Clean up documentation to reflect removed setting
+0/-10   

@qodo-code-review
Copy link
Contributor

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

@sensei-hacker sensei-hacker changed the base branch from master to maintenance-9.x January 22, 2026 17:56
@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@iNavFlight iNavFlight deleted a comment from github-actions bot Jan 22, 2026
@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants