-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Refactor CRSF and SmartPort telemetry #11142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor CRSF and SmartPort telemetry #11142
Conversation
|
IMHO, old sensors should not just be removed. They should be available in a legacy mode for 2 major releases of INAV. This allows for anything that uses those sensors to catch up. There are also sensors missing from SmartPort. Notably:
|
|
So would you suggest to create something like "legacy sensors" for smartport as well. I would not like to mix old and new smartport sensors. btw: I will add missing sensors to smartport and CRSF custom, and you are right pitch and roll are in attitude, it's native frsky sensor "AngleLever" it's expanded to two sensors in ethos. What do you thing about settings for each sensor. ON/OFF? |
|
It would make sense to follow the rotorflight way. Allow users to choose what sensors they want to display. It also makes sense to move off legacy sensors. They are redundant and actually not officially supported. There are some new features coming on ethos that will allow all the custom ones to be 'discovered' by ethos automatically. Until yhay comes out it possible to auto create these and the crsf frames (as done in rotorflight) with a lua script. I will get all this done as soon as you give me go - ahead on this being good for me to dev against. |
7471212 to
4caa885
Compare
|
note: implement #11189 |
0363368 to
1688c68
Compare
* Telemetry scheduler for CRSF and SmartPort
1688c68 to
0bd5cbf
Compare
Note: this PR needs updates in INAV Configurator
Global changes
SmarPort
Ethos DIY sensors, how to add
it's native Ethos functionality, no needed to use any extra LUA script

Ethos sensors
CRSF
CSFR CUSTOMtelemetry sensors
CSFR NATIVE telemetry sensors
For considering
Need to do