-
Notifications
You must be signed in to change notification settings - Fork 73
test: run lint/format/type checks on entire repo #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
let's do issues rather than todo comments ? |
I always open Issues for each TODO I add in code when working on projects. Personally I like having TODO comments in code for stubbed features and ignored warnings/errors as long as they are mirrored in issues to address them. In jupyterlab they even add the issue url to the TODO to cross reference, I'm open to that, I just was unsure if we'd merge this before addressing them or not |
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
I ended up just taking a shot at fixing the mypy errors in It will need a detailed look to make sure I didn't change any examples in a way that changes their intent. |
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
psschwei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinions on linting the whole repo (I could be persuaded either way), would be good for other @generative-computing/mellea-contributors to weigh in
Misc PR
Type of PR
Description
This updates the pre-commit to run linting, formatting, and mypy on the entire repo instead of just certain directories>
This is to bring it in line with the update dev docs in #369
Two future TODOs were added in the config where certain files or error were temporarily ignored
Testing