Skip to content

Conversation

@ajbozarth
Copy link
Contributor

@ajbozarth ajbozarth commented Jan 28, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

This updates the pre-commit to run linting, formatting, and mypy on the entire repo instead of just certain directories>

This is to bring it in line with the update dev docs in #369

Two future TODOs were added in the config where certain files or error were temporarily ignored

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Jan 28, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@psschwei
Copy link
Member

let's do issues rather than todo comments ?

@ajbozarth
Copy link
Contributor Author

let's do issues rather than todo comments ?

I always open Issues for each TODO I add in code when working on projects. Personally I like having TODO comments in code for stubbed features and ignored warnings/errors as long as they are mirrored in issues to address them. In jupyterlab they even add the issue url to the TODO to cross reference, I'm open to that, I just was unsure if we'd merge this before addressing them or not

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth
Copy link
Contributor Author

I ended up just taking a shot at fixing the mypy errors in docs/ in e70c319

It will need a detailed look to make sure I didn't change any examples in a way that changes their intent.

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong opinions on linting the whole repo (I could be persuaded either way), would be good for other @generative-computing/mellea-contributors to weigh in

@ajbozarth ajbozarth mentioned this pull request Jan 29, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: pre-commit does not run linting and mypy on tests and examples

2 participants