-
Notifications
You must be signed in to change notification settings - Fork 73
docs: create contributing doc #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
moves development and contributing documentation into a standard CONTRIBUTING.md and update current docs to reference it Also includes fixes for incorrect test commands and dir structure Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
Note that the ruff and mypy commands documented currently fail. I've opened #370 to address it in a follow up. |
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
@psschwei I've pushed a commit addressing all your inline comments if you'd like to take a look |
psschwei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we're still working on figuring out how to best run the tests, so one question: does the way to run the tests in this PR work with the codebase now as is, or is it a suggestion of how to run the tests that we need to make changes in order to do? I don't want to merge a doc change that isn't how things work at that time, as that would throw a wrinkle when reviewing commit history in the future.
Partially correct, this updates the docs to match how pytest currently work on main. The only caveat is that the suggested ruff and mypy commands will show the issues fixed #376 since they don't specify directories, but only when run directly. Pre-commit currently works since it specifies directories |
|
Status Update: As far as I know this just needs review and approval and is good to merge. I've added a comment on #372 (review) that details the merge conflicts this PR would have with that one depending on which is merged first |
|
LGTM. I'll defer to @ajbozarth and @planetf1 on which PR should merge first |
|
Will be updating this onto latest main later today, once that is done this will be ready for final review |
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
|
I've "rebased" on main to pull in the changes in #372 @planetf1 if you could take a look at a606cc5 and make sure the updates match what you did in #372 the edits to the tutorial and README in that PR were tossed entirely in lieu of updating CONTRIBUTING.md (also probably worth double checking the changes to AGENTS) |
Misc PR
Type of PR
Description
Moves development and contributing documentation into a standard
CONTRIBUTING.mddoc and updates current docs to reference it.Also includes fixes for incorrect test commands and dir structure found while creating the doc
Testing