Skip to content

Conversation

@ajbozarth
Copy link
Contributor

@ajbozarth ajbozarth commented Jan 27, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Moves development and contributing documentation into a standard CONTRIBUTING.md doc and updates current docs to reference it.

Also includes fixes for incorrect test commands and dir structure found while creating the doc

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

moves development and contributing documentation into a standard
CONTRIBUTING.md and update current docs to reference it

Also includes fixes for incorrect test commands and dir structure

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Jan 27, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@ajbozarth
Copy link
Contributor Author

Note that the ruff and mypy commands documented currently fail. I've opened #370 to address it in a follow up.

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth
Copy link
Contributor Author

@psschwei I've pushed a commit addressing all your inline comments if you'd like to take a look

Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we're still working on figuring out how to best run the tests, so one question: does the way to run the tests in this PR work with the codebase now as is, or is it a suggestion of how to run the tests that we need to make changes in order to do? I don't want to merge a doc change that isn't how things work at that time, as that would throw a wrinkle when reviewing commit history in the future.

@ajbozarth
Copy link
Contributor Author

does the way to run the tests in this PR work with the codebase now as is

Partially correct, this updates the docs to match how pytest currently work on main. The only caveat is that the suggested ruff and mypy commands will show the issues fixed #376 since they don't specify directories, but only when run directly. Pre-commit currently works since it specifies directories

@ajbozarth
Copy link
Contributor Author

Status Update:

As far as I know this just needs review and approval and is good to merge. I've added a comment on #372 (review) that details the merge conflicts this PR would have with that one depending on which is merged first

@psschwei
Copy link
Member

LGTM. I'll defer to @ajbozarth and @planetf1 on which PR should merge first

@ajbozarth
Copy link
Contributor Author

Will be updating this onto latest main later today, once that is done this will be ready for final review

@ajbozarth
Copy link
Contributor Author

I've "rebased" on main to pull in the changes in #372

@planetf1 if you could take a look at a606cc5 and make sure the updates match what you did in #372 the edits to the tutorial and README in that PR were tossed entirely in lieu of updating CONTRIBUTING.md (also probably worth double checking the changes to AGENTS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contribution guidelines are not provided in README.

2 participants