Skip to content

London | 26-ITP- January | Daniel Solomon | Sprint 2 | Form controls #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danisoloo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP- January | Daniel Solomon | Sprint 2 | Form controls #977

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea53a65
Revamp index.html to enhance content and structure, including detaile…
Jan 17, 2026
8879093
Merge branch 'CodeYourFuture:main' into feature/form-controls
danisoloo Jan 24, 2026
aebdab1
refactor: cleaning the code
Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 77 additions & 10 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,92 @@
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<title>T-shirt Order Form</title>
<meta name="description" content="Accessible T-shirt order form" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
<p>Please fill in the form below to order your t-shirt.</p>
</header>

<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<form aria-labelledby="order-form">
<h2 id="order-form">T-shirt Order Form</h2>

<!-- REQUIREMENT 1: Customer name -->
<div>
<label for="name">Full Name:</label>
<input
type="text"
id="name"
name="name"
minlength="2"
autocomplete="name"
required
pattern="^(?!\s*$).+"
title="Name must be at least 2 characters and not just spaces."
style="min-height:48px; min-width:200px;"
Copy link
Contributor

@cjyuan cjyuan Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inline CSS. The spec says no CSS. Can you remove all inline CSS to meet the requirement?

To create enough space among elements (to achieve 100 in the Lighthouse accessibility score), you can use <br> or <div> instead.

/>
</div>

<!-- REQUIREMENT 2: Customer email -->
<div>
<label for="email">Email Address:</label>
<input
type="email"
id="email"
name="email"
autocomplete="email"
required
style="min-height:48px; min-width:200px;"
/>
</div>

<!-- REQUIREMENT 3: Colour -->
<fieldset>
<legend>Choose your t-shirt colour:</legend>
<div>
<input type="radio" id="red" name="colour" value="red" required style="min-height:24px; min-width:24px;" />
<label for="red">Red</label>
</div>
<div>
<input type="radio" id="blue" name="colour" value="blue" style="min-height:24px; min-width:24px;" />
<label for="blue">Blue</label>
</div>
<div>
<input type="radio" id="black" name="colour" value="black" style="min-height:24px; min-width:24px;" />
<label for="black">Black</label>
</div>
</fieldset>

<!-- REQUIREMENT 4: Size -->
<fieldset>
<legend>Choose your t-shirt size:</legend>
<label for="size" class="visually-hidden">T-shirt size</label>
<select id="size" name="size" required style="min-height:48px; min-width:200px;">
<option value="" disabled selected>Select a size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</fieldset>

<!-- Submit button -->
<div>
<button type="submit" aria-label="Submit your t-shirt order" style="min-height:48px; min-width:150px;">
Place Order
</button>
</div>
</form>
</main>

<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<p>By Daniel Solomon</p>
</footer>
</body>
</html>
</html>