Skip to content

London | 26-ITP- January | Daniel Solomon | Sprint 2 | Form controls #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
danisoloo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP- January | Daniel Solomon | Sprint 2 | Form controls #977

danisoloo wants to merge 3 commits into from
+77 −10

Conversation

@danisoloo
Copy link

@danisoloo danisoloo commented Jan 17, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Changed Html to give out put for t-shirt

Added name and email sections

Added color type

Tests the website accessibility on lighthouse

Revamp index.html to enhance content and structure, including detaile…
ea53a65 
…d sections on README files and wireframes.
@netlify
Copy link

netlify bot commented Jan 17, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit aebdab1
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974eebe47be060008d8e57d
😎 Deploy Preview https://deploy-preview-977--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@danisoloo danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo changed the title London | 26-ITP-Jan | Daniel Solomon| Sprint 1 | Form controls London | 26-ITP-Jan| Daniel Solomon| Sprint 1 | Form controls Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo changed the title London | 26-ITP-Jan| Daniel Solomon| Sprint 1 | Form controls London | 26-ITP-Jan| Daniel Solomon| Sprint 1 | Form controls Jan 17, 2026
@danisoloo danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo changed the title London | 26-ITP-Jan| Daniel Solomon| Sprint 1 | Form controls London | 26-ITP-Jan| Daniel Solomon| Sprint 2 | Form controls Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@danisoloo danisoloo changed the title London | 26-ITP-Jan| Daniel Solomon| Sprint 2 | Form controls London | 26-ITP-Jan| Daniel Solomon| Sprint 1| Form controls Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@danisoloo danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026
@danisoloo danisoloo changed the title London | 26-ITP-Jan| Daniel Solomon| Sprint 1| Form controls London | 26-ITP-Jan | Daniel Solomon | Sprint 1| Form controls Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo changed the title London | 26-ITP-Jan | Daniel Solomon | Sprint 1| Form controls London | January 2026 | Daniel Solomon | Sprint 1 | Wireframe Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo changed the title London | January 2026 | Daniel Solomon | Sprint 1 | Wireframe London | 26-ITP- January | Daniel Solomon | Sprint 1 | Form controls Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@danisoloo danisoloo changed the title London | 26-ITP- January | Daniel Solomon | Sprint 1 | Form controls London | 26-ITP- January | Daniel Solomon | Sprint 2 | Form controls Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@danisoloo danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
cjyuan
cjyuan reviewed Jan 25, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

It would be better to consistently spell "T-shirt" with an uppercase 'T'.

Form-Controls/index.html
required
pattern="^(?!\s*$).+"
title="Name must be at least 2 characters and not just spaces."
style="min-height:48px; min-width:200px;"
Copy link
Contributor

@cjyuan cjyuan Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inline CSS. The spec says no CSS. Can you remove all inline CSS to meet the requirement?

To create enough space among elements (to achieve 100 in the Lighthouse accessibility score), you can use <br> or <div> instead.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danisoloo @cjyuan