Skip to content

Conversation

@camrun91
Copy link
Collaborator

Description

We had gotten the repo in a state where the IOS example app build was failing. This puts in place a CI test to make sure it passes on PR's

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation update
  • refactor: Code refactoring (no functional changes)
  • perf: Performance improvement
  • test: Test additions or updates
  • build: Build system or dependency changes
  • ci: CI configuration changes
  • chore: Other changes (maintenance, etc.)

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All commit messages follow conventional commits format
  • I have updated the appropriate section in documentation (if needed)

@camrun91
Copy link
Collaborator Author

@jhampton, adding you as a reviewer here for context. This failure is legit; it is the failure I fixed in my other PR. Once that one gets merged, we will be able to update this pr and should see the test pass here.

@camrun91 camrun91 marked this pull request as ready for review January 29, 2026 18:32
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps
Copy link

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

Added new GitHub Actions workflow to test iOS example app builds on pull requests to main branch

  • Sets up macOS runner with Xcode, Node.js 20, Ruby 3.2, and CocoaPods
  • Installs dependencies for both root and example app
  • Uses Expo prebuild to generate native iOS directory
  • Builds iOS app to catch build failures in CI before merge
  • Comment on line 15 says "Pin Xcode" but actually uses 'latest-stable' (not pinned)
  • Missing explicit permissions block (other workflows use contents: read)
  • Missing newline at end of file

Confidence Score: 4/5

  • Safe to merge with minor style improvements recommended
  • Workflow follows good patterns from existing CI workflows, properly sets up iOS build environment, and achieves stated goal of testing iOS builds. Only style issues: misleading comment about pinning Xcode, missing permissions block, and missing newline at EOF
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/example_ios_build.yml New CI workflow to test iOS example app builds on PRs; comment contradicts xcode-version config

Sequence Diagram

sequenceDiagram
    participant PR as Pull Request
    participant GHA as GitHub Actions
    participant Node as Node.js Setup
    participant Expo as Expo Prebuild
    participant Ruby as Ruby/Bundler
    participant Xcode as Xcode Build

    PR->>GHA: Trigger on PR to main
    GHA->>GHA: Checkout repository
    GHA->>Xcode: Select latest-stable Xcode
    GHA->>Node: Setup Node 20 with npm cache
    Node->>GHA: Install root dependencies (npm ci)
    Node->>GHA: Install example dependencies (npm ci)
    GHA->>Expo: Run expo prebuild --clean --platform ios
    Expo->>GHA: Generate ios/ directory with native code
    GHA->>Ruby: Setup Ruby 3.2 with bundler cache
    Ruby->>GHA: Install CocoaPods (pod install)
    GHA->>Xcode: Build iOS app (npm run ios --no-install)
    Xcode->>GHA: Build result
    GHA->>PR: Report success/failure
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

camrun91 and others added 2 commits January 29, 2026 12:37
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
@camrun91 camrun91 changed the title YPE 1178 Add IOS CI build test YPE-1178 Add IOS CI build test Jan 29, 2026
Comment on lines +31 to +33
- name: Install dependencies (example app)
working-directory: example
run: npm ci
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these not get installed when running it at the root?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe they do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants