Make sure to match only on chosen matchers #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: When doing soap requests in tests we often find the same endpoint to be used for multiple calls. The only difference here would be the body that we send to that endpoint. The body was already part of the matchers so adding it works, but for expect_request!'s where the body was omitted an :any was used and thus it would always match. This resulted into some tests that used this library not to find the right expectation for their request. We've now changed the match_score so that any's will be excluded from the match score. So that a closer match with a more specific target will be used over others.
fatboypunk
force-pushed
the
marcel/match-score
branch
from
504ade8 to
9751d52
Compare
Pull Request Test Coverage Report for Build 92d62a061148c2328b8df804192cf391387c76df-PR-23Details
💛 - Coveralls |
sykrish
reviewed
Jan 28, 2026
sykrish
approved these changes
Jan 28, 2026
fatboypunk
force-pushed
the
marcel/match-score
branch
from
9525af6 to
92d62a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
When doing soap requests in tests we often find the same endpoint to be used for multiple calls. The only difference here would be the body that we send to that endpoint.
The body was already part of the matchers so adding it works, but for expect_request!'s where the body was omitted an :any was used and thus it would always match. This resulted into some tests that used this library not to find the right expectation for their request.
We've now changed the match_score so that any's will be excluded from the match score. So that a closer match with a more specific target will be used over others.