-
Notifications
You must be signed in to change notification settings - Fork 25
feat: delete duplicated encryption message - WPB-23062 #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
jullianm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test Results 1 files 301 suites 2m 7s ⏱️ For more details on these failures, see this check. Results for commit 116760e. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the dedicated “encryption info” system message in new conversations to avoid duplicating information that is already shown in the green welcome box.
Changes:
- Stop appending
ConversationEncryptionInfoSystemMessageCellDescriptionfor.newConversationsystem messages. - Remove the now-unused
ConversationEncryptionInfoSystemMessageCellDescriptionimplementation file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Components/ConversationSystemMessageCellDescription.swift | Removes the extra encryption info system message cell from the .newConversation cell composition so only the welcome, started-conversation, guests-allowed (when applicable), file-collaboration, timer, and channel-history-depth cells remain. |
| wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Components/ConversationEncryptionInfoSystemMessageCellDescription.swift | Deletes the dedicated encryption info system message cell class, since the encryption information is now provided solely via the green welcome box. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! As a sanity check is there any more context around this change, like another Jira ticket with more information or conversation in Wire?
WilhelmOks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go to release 14, rather than develop.
Otherwise we will have the 14 release with duplicate info.
Sorry @samwyndham , I forgot to add the other ticket where this change was ask https://wearezeta.atlassian.net/browse/WPB-22948 |
Issue
Delete duplicated encryption message.
We are already showing that message on the text inside the "green box"
Testing
Open a new conversation and check if the message is shown
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: