Skip to content

Conversation

@OlivellaO
Copy link
Collaborator

@OlivellaO OlivellaO commented Jan 27, 2026

TaskWPB-23062 Remove duplicated encryption info system message

Issue

Delete duplicated encryption message.
We are already showing that message on the text inside the "green box"

Captura de pantalla 2026-01-20 a las 12 43 33

Testing

Open a new conversation and check if the message is shown


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Test Results

    1 files    301 suites   2m 7s ⏱️
1 867 tests 1 832 ✅ 27 💤 8 ❌
1 867 runs  1 834 ✅ 27 💤 6 ❌

For more details on these failures, see this check.

Results for commit 116760e.

@datadog-wireapp
Copy link

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 6 Tests failed

testChannelHistoryDepthForNewConversation() from Wire-iOS-Tests.ConversationSystemMessageChannelHistoryDepthSnapshotTests (Datadog) (Fix with Cursor)
ConversationSystemMessageChannelHistoryDepthSnapshotTests.swift:102: XCTAssertNil failed: "Snapshot "414.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/ConversationSystemMessageChannelHistoryDepthSnapshotTests/testChannelHistoryDepthForNewConversation.414-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/ConversationSystemMessageChannelHistoryDepthSnapshotTests/testChannelHistoryDepthForNewConversation.414-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...

    testThatItRendersNewConversationCell_SelfIsCollaborator_AllowGuests() from Wire-iOS-Tests.StartedConversationCellTests (Fix with Cursor)

testThatItRendersNewConversationCell_SelfIsGuest_AllowGuests() from Wire-iOS-Tests.StartedConversationCellTests (Datadog) (Fix with Cursor)
StartedConversationCellTests.swift:187: XCTAssertNil failed: "Snapshot "375.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/StartedConversationCellTests/testThatItRendersNewConversationCell_SelfIsGuest_AllowGuests.375-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/StartedConversationCellTests/testThatItRendersNewConversationCell_SelfIsGuest_AllowGuests.375-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 116760e | Docs | Was this helpful? Give us feedback!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the dedicated “encryption info” system message in new conversations to avoid duplicating information that is already shown in the green welcome box.

Changes:

  • Stop appending ConversationEncryptionInfoSystemMessageCellDescription for .newConversation system messages.
  • Remove the now-unused ConversationEncryptionInfoSystemMessageCellDescription implementation file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Components/ConversationSystemMessageCellDescription.swift Removes the extra encryption info system message cell from the .newConversation cell composition so only the welcome, started-conversation, guests-allowed (when applicable), file-collaboration, timer, and channel-history-depth cells remain.
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/Cells/ConfigurationMessageCell/Components/ConversationEncryptionInfoSystemMessageCellDescription.swift Deletes the dedicated encryption info system message cell class, since the encryption information is now provided solely via the green welcome box.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As a sanity check is there any more context around this change, like another Jira ticket with more information or conversation in Wire?

Copy link
Collaborator

@WilhelmOks WilhelmOks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go to release 14, rather than develop.
Otherwise we will have the 14 release with duplicate info.

@OlivellaO
Copy link
Collaborator Author

Looks good! As a sanity check is there any more context around this change, like another Jira ticket with more information or conversation in Wire?

Sorry @samwyndham , I forgot to add the other ticket where this change was ask https://wearezeta.atlassian.net/browse/WPB-22948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants