fix: update self-deleting system message - WPB-21395 #4186
+57
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 1 files 301 suites 2m 8s ⏱️ For more details on these failures, see this check. Results for commit 00307e1. ♻️ This comment has been updated with latest results. |
OlivellaO
force-pushed
the
fix/selfdeleting-system-message-padding
branch
from
abcc40e to
00307e1
Compare
johnxnguyen
reviewed
Jan 27, 2026
|
|
||
| @available(*, deprecated, message: "Use `init(text:style:color)` instead") | ||
| init( | ||
| attributedText: NSAttributedString, |
Collaborator
There was a problem hiding this comment.
question: will the label still adapt when the preferred content size is changed (in iOS settings)?
Collaborator
Author
There was a problem hiding this comment.
Yes, i've test it and it will
Contributor
|
@OlivellaO don't forget to retarget to 4.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When creating a chat with "Cells" enabled, the self-deleting message was not using the fill width available.
In order to fix that and avoid creating more abstraction or system cells, i've updated DynamicFontLabel to allow to use Attributed String instead of just String (an extra init() was added)
Adding that extra init() we can use it for ConversationWarningSystemMessageCell (updating a bit ConversationEncryptionInfoSystemMessageCellDescription) instead of ConversationSystemMessageCell for ConversationTimerSystemMessageCellDescription.
This will use the full width of the parent view.
As needed extra, padding was added to ConversationWarningSystemMessageCell so text is not showing under the scrollbar.
As a nice to have extra, ConversationFileCollaborationSystemMessageCellDescription was updated to also use ConversationWarningSystemMessageCell so if the text gets too long it will also use the full width properly.
Testing
Steps to test:
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: