fix: remove underline for mentions of own messages in chat bubbles - WPB-20367 #4149
+125
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and add underline for links of other messages in chat bubbles
SyamalaHari
changed the title
Contributor
Test Results1 867 tests 1 840 ✅ 2m 3s ⏱️ Results for commit cae13d5. |
netbe
approved these changes
Jan 23, 2026
| accentColor: (selfUser.zmAccentColor ?? .default).accentColor | ||
| ) | ||
|
|
||
| let detector = try! NSDataDetector(types: NSTextCheckingResult.CheckingType.link.rawValue | |
Collaborator
There was a problem hiding this comment.
todo: what happen if it fails? can we be more flexible here, to not crash
samwyndham
approved these changes
Jan 27, 2026
Contributor
samwyndham
left a comment
samwyndham
left a comment
There was a problem hiding this comment.
Nice work. Apologies for the late review.
Collaborator
|
@SyamalaHari I think you can target 4.15 too here release/cycle-4.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and add underline for links of other messages in chat bubbles
Issue
Fixing two issues:
Solution: Removed globally applying link attributes and applying individually to links and mentions
Testing
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: