-
Notifications
You must be signed in to change notification settings - Fork 1
#082 Curated collections and Prismic #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated formatting and clarified sections in the README.
Updated section headers for clarity and consistency in the README.
|
|
||
| Sticking to this method (vs curating in a CMS) would mean that the Concepts API is THE source of truth for everything, including “display label”, “teaser text” and “hero images”. It would mean only IDs are provided in Prismic and everything is fetched from there. Wellcome Authority descriptions have already been added that way. | ||
|
|
||
| If we stick to the Concepts index being the one source of truth for all content, it makes it very easy to 1) keep FE queries to a minimum, 2) re-use concepts across the site and 3) removes the "dead content in the CMS" concern. It's many of us' favourite solution but the issue is manpower to get it done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main bit of the RFC that we need to fully decide on before we can move on. Potential calls for brain hive @jcateswellcome @kenoir @StepanBrychta @LaurenFBaily . What needs to get build, what's the effort and could Experience devs take a lot of the load to account for WCTSP work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think following wellcomecollection/catalogue-pipeline#3197 we could build a tool that updates the Wellcome Authority source, with validation so changes get propagated to the pipeline without the deploy step required before.
The thing that makes me uncomfortable is that the teaser text in particular is firmly not in the same domain is a collections approved description.
We would also still have the "dead content" issue, just pushed somewhere else potentially more difficult to deal with.
If we can make the teaser text more palatable, and are comfortable supporting a staff facing tool (or be clear its not supported to the same degree as Prismic), maybe we can get around this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an "id / teaser text" pair in prismic a possibility? Does that make things simpler if we're not also dealing with the image set and theme page label, and maybe we don't need it for every theme, just those we want to draw people to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's what you mean but it made me think that maybe the Teaser text issue is separate from the curated Images one? I agree with your point that the teaser text could become dead content at a higher level/pollute our index - but do the "selected" images still have value at that level?
| We could find that the default images are not fitting for a Theme card. For example; | ||
| - If a person card, it's the wrong person or the work of said person. | ||
| - It's a sensitive image | ||
| - There are no images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The image has an extreme aspect-ratio
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered about that, when I looked I couldn't find anything about that. Did you just end up making it work whatever the ratio? (it's here, right?) @davidpmccormick
|
|
||
| ## 5. How to display said lists? | ||
| ## 6. If the content is curated through a CMS, how do we re-use it across the site? | ||
| ## 7. If the content is curated through a CMS, how do we ensure we don't create a ton of dead content? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To what extent do we think dead content would be a real problem (I don't know)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll get away with it if we want said content to be reused across multiple pages tbh. My concern is around the fact that we already struggle making changes to content types and slices because of the many legacy content that don't use the things we want to change in the way they were intended to, and that's why I'm overly cautious of creating content in Prismic. We have half a million themes at the moment, I worry about the about of "Concept content types" in a couple years that are created but unused.
It could be that it's not as big a problem as I make it out to be.
| #### 1. We create a new Slice that makes this process more secure and more intuitive | ||
| Ideally, this slice would also serve for Themes. For now, I’m only thinking about a way to identify the Slice better in the code (an ID field?) and then a repeatable Text field that would allow for an infinite number of IDs, links or Integration fields to be provided. A select field would also be required to indicate which endpoint is to be used (concept or work) We could then use that to fetch the relevant content. This also addresses ISSUE 3 in Featured Themes. | ||
|
|
||
| #### 2. We create a new Content type that can be linked to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this option, and we could fallback to the label and image ids referenced in the wellcome authority if some fields are not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanting to double check which option you're referring to, 1 or 2?
| We could find that the default images are not fitting for a Theme card. For example; | ||
| - If a person card, it's the wrong person or the work of said person. | ||
| - It's a sensitive image | ||
| - There are no images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest if there's no images that we exclude those themes and don't feature them at all. This theme page component is designed to draw people in through the imagery which is why its been given so much real estate so using any kind of place holder here would be wasting this space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is we won't know there's no images until we try to fetch them. So we absolutely can add it to the logic, but it'll be interesting to see how often this happens because it means we needs to get more concepts to allow for some of them getting filtered out.
| Where do Editorial/Collections colleagues browse our themes and works to find what they find interesting? | ||
|
|
||
|
|
||
| ## 4. How and where to list selected works and concepts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- How to select curated works and concepts? - I would say 'search for them' but that is a can of worms of course. Conceptually though why/how do we want this to be different to the method of discovery for all our users? Do we assume staff have distinct needs e.g. looking for 'new' themes or ones related to upcoming exhibitions etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will heavily depend on 1) what the carousel's categories are 2) how much we can rely on queries to create those carousels dynamically
Themes were impossible to search in the recent past; now we have the Themes search that Robert released behind a toggle. Our users don't have access to it and it's only a keyword search.
Works are easier, but it depends on the carousel categories. It's easy enough to find relevant works if the carousels we want are using our existing filters (e.g. Works by Audrey Amiss). But other categories might cause us to wonder. For example, "New online" was hard to find a couple months ago and they would have to be hand-picked by those who were aware of what was new online. So if we have intricate carousel categories, such as (making it up) "British women in science", then how do we make it easy for editors to find which works are most relevant? etc.
Might be a non-question if we keep it simple and dynamic (might still have to allow for new endpoints/filters/back end magic)
| 1. Could we only use an approved list of themes? | ||
|
|
||
|
|
||
| ## 1. How to curate which images are shown on a theme card? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chats with Lauren:
We have a limited number of Person concepts with images. We find those and have a human or a robot go through them and select portraits. Said image is then added as displayImages in the Concept pipeline.
For the other types, we're happy with the first four images returned. If one of them is offensive, then that theme gets flagged through time and then we can curate that selection as well (still with displayImages in the API response)
|
|
||
| **Here are the various issues we are aiming to solve:** | ||
| 1. How to curate which images are shown on a theme card? | ||
| 2. How to curate the teaser text of a theme card? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chats with Lauren:
Add a section about the curation of the label.
If that is necessary, it has to get corrected at the API level (e.g. british spelling). Shouldn't happen very often.
| If no image is specified in the concept response, the current fallback query fetches four images, regardless of the type of card and the size of the image. | ||
|
|
||
| ## 2. How to curate the teaser text of a theme card? | ||
| ### Why do we need to be able to do this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chats with Lauren:
We will start with NO teaser on ANY cards, except the landing page. The landing page copy will be editable through Prismic. (so we need to find a solution for that)
wellcomecollection/wellcomecollection.org#12512
Originally a document, we found it would be a longer conversation than expected and I want it documented properly, so opening the conversations as an RFC.
Read document here