-
Notifications
You must be signed in to change notification settings - Fork 234
ci: add Python 3.13 to CI matrix; build: declare support for 3.13 #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
+ Coverage 87.47% 87.78% +0.31%
==========================================
Files 20 20
Lines 2586 2767 +181
==========================================
+ Hits 2262 2429 +167
- Misses 324 338 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 2
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Metadata Forbids Tested Python Version
The requires-python constraint ">=3.10,<3.13" excludes Python 3.13, but the CI workflow now tests Python 3.13. This creates a mismatch where CI tests a Python version that the package metadata explicitly forbids, causing installation failures in CI and preventing users from installing the package on Python 3.13 despite the PR's intent to add support for it.
pyproject.toml#L4-L5
Lines 4 to 5 in f80fd2b
| description = "Platform for individual detection from airborne remote sensing including trees, birds, and livestock. Supports multiple detection models, adding models for species classification, and easy fine tuning to particular ecosystems." | |
| readme = "README.md" |
ethanwhite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the error results from imghdr being deprecated in 3.11 and removed in 3.13. It appears that requiring sphinx>=6.2 might fix this (if it doesn't break anything else)
|
@ethanwhite I tried Checked up sphinx and probably we may try something like https://github.com/sphinx-doc/sphinx/blob/62619bd5a2e8b203ff81b50456508bd7d2583920/.github/workflows/main.yml#L225 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| description = "Platform for individual detection from airborne remote sensing including trees, birds, and livestock. Supports multiple detection models, adding models for species classification, and easy fine tuning to particular ecosystems." | ||
| readme = "README.md" | ||
| requires-python = ">=3.10,<3.13" | ||
| requires-python = ">=3.10,<3.15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version constraint allows untested Python 3.14 with known issues
Medium Severity
The requires-python constraint was changed to >=3.10,<3.15, which declares support for Python 3.14. However, the CI configuration explicitly comments out Python 3.14 with the note "Uncomment after issue #1266 is resolved," indicating Python 3.14 has known issues. Users on Python 3.14 could install this package believing it's supported. The constraint likely meant to use <3.14 to only add Python 3.13 support.
Note
Expand Python support and CI coverage
3.13(with3.14commented pending issue Add Python 3.14 #1266)pyproject.tomland README badge to>=3.10,<3.15docutils; requiresphinx>=8.0.2Written by Cursor Bugbot for commit 871d53e. This will update automatically on new commits. Configure here.