Closes Issue #133 - removes required vmware-password argument #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Signed-off-by: Joel McLean <joel.mclean@micron21.com>
Signed-off-by: Joel McLean <joel.mclean@micron21.com>
joelmclean
force-pushed
the
issue-133-remove-passwd-arg
branch
from
71ced26 to
2f561be
Compare
Author
This commit was to rebase with the signoff, required by DCO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes required vmware-password argument
--vmware-password becomes optional.
if supplied, works normally.
if not supplied, interactive prompt for password appears
if not interactive, returns error.
I'm not exactly the worlds best developer, and am very new to golang, so be kind, feel free to improve.
We are using this fork locally.