fix: return cluster shared volumes [CLOUD-627] #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huksley
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds support for shared volumes in cluster objects by introducing a SharedVolume dataclass and updating the Cluster model to include a list of shared volumes. The changes also improve type hints and refactor the clusters example to use variables for better maintainability.
Changes:
- Added
SharedVolumedataclass to represent cluster shared volumes with fields for id, name, size, and mount point - Updated
Clusterdataclass to include ashared_volumesfield - Added type hint for
HTTPClientinClustersService.__init__ - Refactored clusters example to use variables and display shared volume information
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| verda/clusters/_clusters.py | Added SharedVolume dataclass, updated Cluster to include shared_volumes field, and improved type hints |
| examples/clusters_example.py | Refactored to use variables for cluster configuration and added shared volumes display in output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 3 commits
January 21, 2026 10:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster get by id API API returns
returns cluster shared volumes but we don't expose in Python SDK.
This fixes that.