Skip to content

fix: set isLoading: false when id is undefined #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TatsuyaYamamoto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: set isLoading: false when id is undefined #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react-tweet/src/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ export const useTweet = (
)

return {
// If data is `undefined` then it might be the first render where SWR hasn't started doing
// If id is provided but data is `undefined` then it might be the first render where SWR hasn't started doing
// any work, so we set `isLoading` to `true`.
isLoading: Boolean(isLoading || (data === undefined && !error)),
isLoading: Boolean(
isLoading || (id !== undefined && data === undefined && !error)
),
data,
error,
}
Expand Down