Allow loopback edges #299
Open
Allow loopback edges #299
+44
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
adriannesoike
left a comment
adriannesoike
left a comment
There was a problem hiding this comment.
Please provide example of expected display. I wasn't able to see the behavior when I checked out to your branch. Thanks!
| onCopySelected={this.onCopySelected} | ||
| onPasteSelected={this.onPasteSelected} | ||
| layoutEngineType={this.state.layoutEngineType} | ||
| allowLoopbackEdge={true} |
Contributor
There was a problem hiding this comment.
Please expose this in example similar to allowMultiselect
| graph.edges = [...graph.edges, viewEdge]; | ||
| this.setState({ | ||
| graph, | ||
| selected: viewEdge, |
Contributor
There was a problem hiding this comment.
Think this code needs to be updated (see merge conflicts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Bug: Edges with a target node equaling the source node should display as a loopback edge which can be selected #101
Added
allowLoopbackEdgepropertyIf
allowLoopbackEdgeis set to true, the mouse enter allows to set theedgeEndNodeto the node from which the edge started.