Bug introduced when addressing PR feedback #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradhe
requested review from
Copilot,
jo-sm,
konstantinoscs,
sammuti and
socksy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the cleanup_stale_uv_lock_files function where inverted logic caused the function to attempt deletion of non-UV files while skipping actual UV lock files. The fix negates the condition check and adds a regression test.
Changes:
- Inverted the logic in
cleanup_stale_uv_lock_filesto correctly filter UV lock files - Added comprehensive test coverage to verify only UV lock files are processed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sammuti
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops.
cleanup_stale_uv_lock_filesis excluding/including the wrong files, leading to attempts to delete the wrong things. This PR inverts the logic, and adds a test to prevent it from regressing.