fix(ci): fix clippy warnings and remove deprecated rocksdb tests #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all clippy warnings that were causing CI failures in PR #494.
Changes:
Fix needless_borrows_for_generic_args in terraphim_update (4 instances)
&format!()toformat!()inbin_install_path()callsFix unnecessary_unwrap in terraphim-session-analyzer tests
if file_op.agent_context.is_some()check toif let Some(agent_context) = &file_op.agent_context.as_ref().unwrap()callFix needless_question_mark in terraphim_agent repl/mcp_tools (2 instances)
Ok()wrapping around async callsextract_paragraphs()andreplace_matches()methods now directly return ResultsFix wildcard_in_or_patterns in terraphim_agent repl/mcp_tools (1 instance)
Some("markdown") | _toSome("markdown") | Nonepattern**Add `#[allow(dead_code)]`` for McpToolsHandler
repl-mcpfeature is not currently used, marking as allowed until neededRemove deprecated rocksdb feature tests
test_save_and_load_rocksdb()from settings.rs (88 lines)test_save_and_load_thesaurus_rocksdb()from thesaurus.rs (69 lines)unexpected_cfgsclippy errorsImpact:
-D warningsTesting: