fix: changelog version links now include pathname #25
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vocs changelog component used relative hash links (#v1.0.0) which navigated to /#v1.0.0 instead of /changelog#v1.0.0. This pnpm patch prepends window.location.pathname to the href. Upstream issue: wevm/vocs#387 Amp-Thread-ID: https://ampcode.com/threads/T-019be6cb-3f1e-745a-b6c3-d8baa90dc49e Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Clicking on versions in the changelog redirects to
https://docs.tempo.xyz/#v1.0.0-rc.5instead of scrolling to that version onhttps://docs.tempo.xyz/changelog.Root Cause
The vocs changelog component used relative hash links (
#v1.0.0) which navigated to/#v1.0.0instead of/changelog#v1.0.0.Solution
This PR adds a pnpm patch to vocs that prepends
window.location.pathnameto the href, making the links work correctly on non-root pages.Upstream
Filed issue for a proper fix: wevm/vocs#387
cc @alexey