feat: context propagation and dynamic type analysis #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces two major enhancements to the requestmigrations library:
rm.For(r)pattern that makes request context required by designinterface{}fields where concrete types are determined at runtimeChanges
Context Propagation (
rm.For(r)Pattern)Migratortype: A request-scoped handle created viarm.For(r)that holds the HTTP request context and user versionMarshal/Unmarshalnow live onMigratorinstead ofRequestMigrationTypeMigrationinterface: Now acceptscontext.Contextparameter for cancellation, logging, and tenant-specific logicUserVersionFromContext(ctx)to retrieve user version inside migrationsBefore:
After:
Runtime Type Detection for Dynamic Fields
BuildFromValuemethod: Inspects runtime types before JSON serialization to detect concrete types ininterface{}fieldsPagedResponse{Content: []EndpointResponse{}}Documentation
docs/context_propagation.md- Design doc for therm.For(r)patterndocs/runtime_type_detection.md- Design doc for dynamic field supportdocs/bulk_registration.md- Design doc for bulk migration registrationTests
rm.For(r).Marshal/Unmarshalpatterninterface{}field migrationsUserVersionFromContext()Breaking Changes
TypeMigrationinterface signature changed: methods now requirecontext.Contextas first parameterMarshal/Unmarshalmoved fromRequestMigrationtoMigratorWithUserVersion()replaced byFor()Test Plan