Add configurable container runtime variable to Makefile #893
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds flexibility to the Makefile by introducing a configurable container runtime variable, allowing users to use alternative container runtimes like Podman without modifying the Makefile.
Changes:
- Added
CONTAINER_RUNTIMEvariable with conditional assignment defaulting todocker - Replaced all hardcoded
dockercommands in the Makefile with the$(CONTAINER_RUNTIME)variable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduce a
CONTAINER_RUNTIMEvariable that defaults todockerbut can be overridden to use alternative runtimes likepodman. Replace hardcodeddockercommands inrun,logs,console, andbuildtargets with this variable.Why
Allow users with different container runtimes to use the Makefile without modification.