Skip to content

Visual Studio #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sshirokov wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Visual Studio #63

sshirokov wants to merge 14 commits into from

Conversation

@sshirokov
Copy link
Owner

@sshirokov sshirokov commented Aug 26, 2016 •
edited
Loading

Work towards fixing #53 by letting this project compile in Visual Studio without breaking the existing CI build

Work is being done with VS2015

How?

  • Manage to build a static lib in windows
  • Without warnings
  • Make sure it even kinda works
  • Set up a solution structure that can co-exist
  • Build a windows exe depending on the static lib
  • Make sure the exe works
  • Nice, Good Job!

Bugs

  • Make sure we can intersect jaws and jaws2
  • Consider the text vs binary differences (is this still a thing)
  • csgtool\Debug>csgtool audit ..\tests\fixtures\cube.txt.stl crashes
  • Other Windows things?
  • Run the test suite

Bonus Rount

  • Windows CI build

@sshirokov sshirokov changed the title Visual studio Visual Studio Aug 26, 2016
@sshirokov
More specific types
6aae0eb
@sshirokov
Define the platform specific IO
ee6d466
@sshirokov
The start of a solution and a static lib project
e29b05e
@sshirokov
Include the src/*.[ch] as wildcards
93512a5
@sshirokov
Even More Wildcards
8ab94ee
@sshirokov
A second project for the exe
8bc6b45 
Also, a rename of the `csgtool` project to `libcsg` and `csgtool`
becoming the binary project
@sshirokov
Depend and compile
23904fc
@sshirokov
O_BINARY on all open()
2057361 
Because windows has a destinction, and binary files can sometimes read
wrong because of it.

REMEMBER THE PAST? IT LIVES FOREVER WITH US NOW!
@sshirokov sshirokov mentioned this pull request Aug 26, 2016
Open
@Shazib
Copy link

Shazib commented Dec 5, 2016 •
edited
Loading

Any word on when the visual studio version will be done? 😃

@sshirokov
Copy link
Owner Author

sshirokov commented Dec 5, 2016

Any word on when the visual studio version will be done? 😃

I will take a few more stabs this week, and if I stab the right parts, hopefully this week? If you don't hear from me by then, please remind me again :(

Sorry for taking forever on this one

@Shazib
Copy link

Shazib commented Dec 6, 2016

Awesome 👍

sidenote: Having trouble running a 64-bit build? it builds fine and loads files fine, then dies around 'poly_classify_vertex'

Is 64-bit not supported?

Thanks!

@sshirokov
Copy link
Owner Author

sshirokov commented Dec 7, 2016

Is 64-bit not supported?

It should be since I ran this in production in 64 bit linux the whole time. What kind of failure did you see? The remaining fixes I anticipate here are mostly around disk IO thanks to windows' distinction of "binary" files. 😿

@Shazib
Copy link

Shazib commented Dec 8, 2016

I think you're right regarding the diskIO being the cause... The crashes happened seemingly randomly at various places in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sshirokov @Shazib