feat(kg): add --internal-cidr flag to filter IP auto-detection #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new --internal-cidr flag that allows users to specify which CIDRs should be considered during internal IP auto-detection. This flag can be specified multiple times to allow multiple CIDRs. When set, only IPs within these CIDRs will be selected as the internal IP, preventing incorrect IP selection (e.g., when CiliumInternalIP is chosen over the real node IP due to lexicographic sorting). Example usage: --internal-cidr=192.168.0.0/16 --internal-cidr=$(NODE_IP)/32 Also update manifests for cilium and flannel deployments to use this flag with NODE_IP from Kubernetes Downward API. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps
force-pushed
the
feature/internal-cidr-flag
branch
from
2a04879 to
0ada870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
--internal-cidrflag that filters internal IP auto-detection by specified CIDRs. This flag can be specified multiple times.Motivation
When running Kilo with CNI plugins like Cilium, the auto-detected internal IP may incorrectly select overlay network IPs (e.g., 10.244.x.x) instead of actual node IPs (e.g., 192.168.x.x) due to lexicographic sorting in IP selection. This causes routing issues as
privIfacegets set to the wrong interface.Usage
Changes
--internal-cidrflag tocmd/kg/main.gomesh.New()to acceptallowedInternalCIDRsparametergetIP()indiscoverips.goto filter IPs by allowed CIDRsNODE_IPfrom Downward APITest plan
--internal-cidrflag in environment with Cilium