Skip to content

Conversation

@MohammadKHC
Copy link

NOTE: This removes some of @Throws annotations from the native sourceset.
without this building for native fails.

w: KLIB resolver: The same 'unique_name=kotlin-stdlib-common' found in more than one library: /home/mohammedkhc/okio/okio/build/kotlinTransformedMetadataLibraries/commonMain/org.jetbrains.kotlin-kotlin-stdlib-2.3.0-commonMain-1ooqQQ.klib, /home/mohammedkhc/okio/okio/build/kotlinTransformedMetadataLibraries/hashFunctions/org.jetbrains.kotlin-kotlin-stdlib-2.3.0-commonNonJvmMain-1ooqQQ.klib
e: file:///home/mohammedkhc/okio/okio/src/nativeMain/kotlin/okio/DeflaterSink.kt:31:3 Member overrides different '@Throws' filter from 'interface Sink : Closeable'.
e: file:///home/mohammedkhc/okio/okio/src/nativeMain/kotlin/okio/DeflaterSink.kt:43:3 Member overrides different '@Throws' filter from 'interface Sink : Closeable'.
e: file:///home/mohammedkhc/okio/okio/src/nativeMain/kotlin/okio/DeflaterSink.kt:69:3 Member overrides different '@Throws' filter from 'interface Closeable : Any'.
e: file:///home/mohammedkhc/okio/okio/src/nativeMain/kotlin/okio/FileSystem.kt:116:3 Member overrides different '@Throws' filter from 'interface Closeable : Any'.
e: file:///home/mohammedkhc/okio/okio/src/nativeMain/kotlin/okio/InflaterSource.kt:27:3 Member overrides different '@Throws' filter from 'interface Source : Closeable'.
e: file:///home/mohammedkhc/okio/okio/src/nativeMain/kotlin/okio/InflaterSource.kt:42:3 Member overrides different '@Throws' filter from 'interface Closeable : Any'.

@JakeWharton
Copy link
Collaborator

I need to check whether the throws change affects the exception handling from Swift/Objective-C.

@MohammadKHC
Copy link
Author

Sure! And maybe even find out why does this even happen in the first place??

Also I did run ./gradlew kotlinUpgradeYarnLock and commit changes to this PR.

@omarismail94
Copy link

Can we first merge: #1690 to not force Kotlin 2.3 on downstream consumers? Upgrading to Kotin 2.3 without setting languageVersion, apiVersion, and coreLibrariesVersion forces consumer of Okio to update their KGP to 2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants