p-token: Add self-revoke delegate #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Jan 21, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just two tiny nits, which you can take or leave
| unsafe { | ||
| validate_owner( | ||
| if source_account.delegate() == Some(authority_info.key()) { | ||
| authority_info.key() |
Contributor
There was a problem hiding this comment.
nit: there's no actual difference, and I'm not sure if this impacts performance, but I find it slightly clearer to use source_account.delegate() here
Suggested change
| authority_info.key() | |
| source_account.delegate() |
Comment on lines
+170
to
+172
| assert!(account.is_some()); | ||
|
|
||
| let account = account.unwrap(); |
Contributor
There was a problem hiding this comment.
micro-nit: there's no need to assert account.is_some() if we're unwrapping in the next line -- it'll panic either way!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently only the account owner is able to revoke a delegate, although there are use-cases where it would be interesting for a delegate to revoke itself.
Solution
Update the
revokeimplementation to allow a delegate to revoke itself.