p-token: Add delegate support to unwrap_lamports
#120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Jan 21, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great to me! Just a tiny nit, which you can take or leave
Comment on lines
+824
to
+826
| // When we try to unwrap 2_000_000_000 lamports, we expect a | ||
| // `TokenError::InsufficientFunds` error since only 1_000_000_000 | ||
| // lamports are delegated. |
Contributor
There was a problem hiding this comment.
This behavior makes sense to me -- there's an argument that using an amount of None with a delegate should unwrap the rest of the delegated amount, but that seems like more of a footgun than anything else
| } | ||
|
|
||
| #[test] | ||
| fn unwrap_lamports_from_multisig() { |
Contributor
There was a problem hiding this comment.
micro-nit: This isn't unwrapping the lamports from the multisig, but rather from a multisig-owned account. I got a bit confused, so maybe just update the naming?
Suggested change
| fn unwrap_lamports_from_multisig() { | |
| fn unwrap_lamports_with_multisig_owner() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently it is not possible to use a delegate to
unwrap_lamports.Solution
Add delegate support to
unwrap_lamports. The delegate implementation works similarly to how it works ontransfer: