SK-2496: extract hard coded values to constants #229
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| response_object = { | ||
| "token": actual_token, | ||
| "signed_token": signed_token | ||
| ResponseField.TOKEN: actual_token, |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow data token (non-sensitive, not an auth token)
| "token": record.token, | ||
| "error": record.error, | ||
| "request_id": request_id | ||
| ResponseField.TOKEN: record.token, |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow data token (non-sensitive, not an auth token)
| "token": record.token, | ||
| "value": record.value, | ||
| "type": value_type | ||
| ResponseField.TOKEN: record.token, |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow data token (non-sensitive, not an auth token)
| def parse_tokenize_response(api_response: V1TokenizeResponse): | ||
| tokenize_response = TokenizeResponse() | ||
| tokenized_fields = [{"token": record.token} for record in api_response.records] | ||
| tokenized_fields = [{ResponseField.TOKEN: record.token} for record in api_response.records] |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow data token (non-sensitive, not an auth token)
| DETAILS = 'details' | ||
| MESSAGE = 'message' | ||
| ERROR_FROM_CLIENT = 'error_from_client' | ||
| TOKEN = 'token' |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow data token (non-sensitive, not an auth token)
| KEY_ID = 'keyID' | ||
| TOKEN_URI = 'tokenURI' | ||
| CREDENTIALS_STRING = 'credentials_string' | ||
| API_KEY = 'api_key' |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow configuration field (non-sensitive, not a secret)
| TOKEN_URI = 'tokenURI' | ||
| CREDENTIALS_STRING = 'credentials_string' | ||
| API_KEY = 'api_key' | ||
| TOKEN = 'token' |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow data token (non-sensitive, not an auth token)
| V1DetokenizeRecordRequest( | ||
| token=item.get('token'), | ||
| redaction=item.get('redaction', RedactionType.DEFAULT) | ||
| token=item.get(ResponseField.TOKEN), |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: semgreprules.check-sensitive-info Error
There was a problem hiding this comment.
Skyflow data token (non-sensitive, not an auth token)
Why:
Following the Node SDK linting audit and refactor, this ticket focuses on applying the same linting standards and best practices across Python SDK v2.
The goal is to ensure consistent use of constants over hardcoded values across Python SDK v2, improving maintainability and readability.
Goal:
Update linting rules to discourage hardcoded literals where constants should be used.
Refactor existing code to replace hardcoded values with well-defined constants.