aadarsh-st/SK-2510-Fixed all the mentioned issue #279
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
aadarsh-st
requested review from
Devesh-Skyflow,
Copilot,
saileshwar-skyflow and
skyflow-bharti
There was a problem hiding this comment.
Pull request overview
This PR fixes multiple issues identified in ticket SK-2510, including a bug in URL parameter replacement, improvements to error handling for HTTP responses, and enhanced error messages for bearer token validation.
Changes:
- Fixed a bug in
fillUrlWithPathAndQueryParamswhere only the first path parameter was being replaced - Enhanced error handling in connection controller to properly consume response bodies and prevent connection leaks
- Improved bearer token error messages to clarify that tokens may be invalid or expired
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/index.ts | Fixed variable reference bug where url was used instead of filledUrl in the replace operation |
| test/vault/utils/utils.test.js | Updated test expectation to reflect correct behavior of replacing all path parameters |
| src/vault/controller/connections/index.ts | Enhanced error response handling with proper JSON/text parsing and body consumption |
| src/error/messages/index.ts | Improved error messages to indicate bearer tokens may be invalid or expired |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.