Skip to content

[UIK-4704][d3-chart] added showPercentValueInTooltip prop for Area/Bar/Cigarette/Histogram/Line charts + updated types #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
slizhevskyv-semrush wants to merge 3 commits into
base: release/v16
Choose a base branch
from
Open

[UIK-4704][d3-chart] added showPercentValueInTooltip prop for Area/Bar/Cigarette/Histogram/Line charts + updated types #2684

slizhevskyv-semrush wants to merge 3 commits into from

Conversation

@slizhevskyv-semrush
Copy link
Contributor

@slizhevskyv-semrush slizhevskyv-semrush commented Jan 28, 2026

Changelog

@semcore/d3-chart

Added

  • showPercentValueInTooltip prop for Area/Bar/Cigarette/Histogram/Line charts.

Fixed

  • Fixed types by removing unsupported showTotalInTooltip prop from certain chart components.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@slizhevskyv-semrush
[UIK-4704][d3-chart] added showPercentValueInTooltip prop for Area/Ba…
e7034e0 
…r/Cigarette/Histogram/Line charts + updated types
@slizhevskyv-semrush
Copy link
Contributor Author

slizhevskyv-semrush commented Jan 28, 2026

@ilyabrower I've updated chart component's types which doesn't have any logic related to showTotalInTooltip. Let me know if it's still needed. Thanks!

ilyabrower
ilyabrower reviewed Jan 28, 2026
View reviewed changes
slizhevskyv-semrush and others added 2 commits January 28, 2026 14:01
@slizhevskyv-semrush @ilyabrower
Update semcore/d3-chart/src/component/Chart/AbstractChart.tsx
910ceed 
Co-authored-by: ilyabrower <ilia.brauer@semrush.com>
Signed-off-by: slizhevskyv-semrush <uladzislau.slizheuski@semrush.com>
@slizhevskyv-semrush @ilyabrower
Update semcore/d3-chart/src/component/Chart/AbstractChart.tsx
f76a357 
Co-authored-by: ilyabrower <ilia.brauer@semrush.com>
Signed-off-by: slizhevskyv-semrush <uladzislau.slizheuski@semrush.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyabrower ilyabrower ilyabrower approved these changes

@Valeria-Zimnitskaya Valeria-Zimnitskaya Awaiting requested review from Valeria-Zimnitskaya

Assignees

No one assigned

Labels

d3-chart

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slizhevskyv-semrush @ilyabrower