tests: add modernize check

[murfffi]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @murfffi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's build and testing infrastructure by integrating a new modernize code analysis check. It introduces a consolidated checks target in the Makefile, which now includes the new modernize tool alongside existing tidy and vulnerability checks. The primary goal is to ensure the codebase adheres to modern Go practices and patterns, improving maintainability and consistency.

Highlights

• New checks Makefile Target: A new checks phony target has been added to the Makefile, consolidating the execution of check_tidy, check_vuln, and the newly introduced check_modern targets.
• Introduction of check_modern: A new check_modern Makefile target has been added, which runs the modernize tool from golang.org/x/tools/gopls to identify and suggest modern Go code practices. This check will exit with a non-zero status if issues are found.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a modernize check to the Makefile to help keep the Go code up-to-date with modern practices. It also groups this new check with existing ones under a new checks target. The implementation is correct, but I've suggested an improvement for managing tool dependencies. Instead of pinning versions directly in the go run commands, it would be more maintainable to use a tools.go file to track tool dependencies within the module's go.mod file. This centralizes version management and is a common practice in Go projects.