[fix] Records requests during iteration even though it is not serialized #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavocabral
commented
Jan 9, 2020
| this.server.pretender.handledRequest = (verb, path, request) => { | ||
| if (verb === 'DELETE') this.recordRequest(request); | ||
| return originalHandler(verb, path, request); | ||
| }; |
Author
There was a problem hiding this comment.
Not an ideal solution. However, it was inspired on:
https://github.com/salsify/ember-cli-pact/blob/master/addon-test-support/mock-provider/pretender.js#L31
gustavocabral
force-pushed
the
fix_record_not_serialized_request
branch
from
d5a6f42 to
9f5f41f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Changes
recordRequestthrough pretender'shandledRequestonmock-provider/mirage.js.Tests