This repository was archived by the owner on Jan 23, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 122
Fix Pagination #1982
Open
Utsav-Ladani
wants to merge
10
commits into
develop
Choose a base branch
from
fix/multiple_shortcode_pagination
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix Pagination #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the pagination for 'rtmedia_gallery' shortcode. Now it is working even if there are multiple shortcode on same page.
BREAKING CHANGE: Masonary Layout not working.
…esign BREAKING CHANGE: Extra sort parameter will not support
Collaborator
Author
|
I fixed the Pagination issue for the shortcode and media gallery. Please check and let me know if there is something wrong or broken. Also, check out this PR in the CC: @pavanpatil1, @kjnanda |
Contributor
|
@pavanpatil1 Handing over this issue to you! |
Contributor
|
Hi @Utsav-Ladani, verified the fix and it seems working fine. However, after clicking onload more the previous media are not visible. Please check. loadmore.mp4 |
Collaborator
Author
|
Hello @pavanpatil1, I fixed the issue. Now previous content is visible after loading new content in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pagination
Types of changes
Details
NumericalandLoad Morepagination usingbackbone.jsviews and collections.Note
rtMedia-Proto fix the UI issue. So update both plugins' code to get the correct result.Related PRs