Skip to content

A few updates #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
seawander wants to merge 10 commits into
base: master
Choose a base branch
from
Open

A few updates #14

seawander wants to merge 10 commits into from

Conversation

@seawander
Copy link

@seawander seawander commented May 17, 2023

  1. Hard coded the Stokes parameters for earlier observations (reducing data in 2014-2015 like MWC 758).
  2. Allow the usage of sky frames from other observations (for star hopping).
  3. Ks data centers also prescribed.
  4. Parallactic angle correction, incorporated from PYNPOINT (but the actual difference for recent observations are way less than north uncertainty).
  5. Rescaling rectangular pixels to square pixels (from Christian Ginski's two-liner).
  6. For output target name, use only the OBJECT files (due to the 2nd point here).

Welcome back!

-Bin

seawander added 8 commits May 5, 2022 13:18
@seawander
default center for any Ks data set
3efc830 
default center for any Ks data set
@seawander
minor typo correction
0505c23
@seawander
geometric distortion correction from C. Ginski
6f59490 
Updated Christian Ginski's correction for geometric distortion. Search for `#geometric correction code from Christian Ginski` for the 5 lines.
@seawander
Output target name fix
65d87a8 
Use only the `OBJECT` files, since people might use `SKY` frames from a different target (especially in star hopping observations).
@seawander
Utils for parallactic angle correction
f3f3d3c 
Adjusted from PynPoint `psfpreparation.py` function
@seawander
Write parallactic angles to preprocessed folder
d1da46e 
For potential uses of parallactic angles (instead of loading the `ESO TEL PARANG START` or `ESO TEL PARANG END` headers). 

The input `START` and `END` parallactic angles are already after correction, and the output values are from their mean calculated using the `compute_mean_angle` function.
@seawander
Enable the use of SKY frames from other targets
f732ad4 
... especially for star hopping observations.
@seawander
Hard-coded Stokes parameters for old observations
43aa1da 
1. Hard-coded Stokes parameters are based on the 'ESO INS4 DROT3 POSANG' header values, when such parameters were not available back then. Tested on MWC 758 and NGC 1068 in 2014-2015, results look good.
2. Also loosened the requirement of Q+, Q-, U+, U- for the above data.
@seawander seawander requested a review from robvanholstein as a code owner May 17, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robvanholstein robvanholstein Awaiting requested review from robvanholstein robvanholstein is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seawander