refactor: Address cargo and clippy warnings #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit doesn't address dead-code warnings, as this is a WIP branch. When the branch is ready for the PR, the dead/unused code can be reviewed
Ben-PH
commented
Jan 13, 2026
Comment on lines
24
to
29
| device_major(dev) | ||
| libc::major(dev) | ||
| } | ||
|
|
||
| #[cfg(not(target_os = "macos"))] | ||
| fn device_minor(dev: u64) -> u32 { | ||
| device_minor(dev) |
Collaborator
Author
There was a problem hiding this comment.
The only part that changes logic. @Zorlin please confirm?
Collaborator
Author
There was a problem hiding this comment.
@Zorlin is that something you'd like to delegate to me?
Collaborator
There was a problem hiding this comment.
Hi, reply by email didn't seem to work
We don't want any libc functions in the codebase as it makes musl builds near impossible
Collaborator
Author
There was a problem hiding this comment.
I've reverted that change, and will look into moving to musl in another branch.
If I run cargo test, it fails on dragonfly not being installed. assuming that test works on your machine, it should be good to go: If I did my job right, there isn't any changes to logic.
Collaborator
|
Libc is out. We need musl builds.
…On Tue, 13 Jan 2026, 22:54 Ben, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In patches/proxmox-compression/src/tar.rs
<#2 (comment)>:
> - device_major(dev)
+ libc::major(dev)
}
#[cfg(not(target_os = "macos"))]
fn device_minor(dev: u64) -> u32 {
- device_minor(dev)
The only part that changes logic. @Zorlin <https://github.com/Zorlin>
please confirm?
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKONLHPOP6PTCTG6IMLDRD4GUBLHAVCNFSM6AAAAACRRVXM62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNJWGI2TCNJZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ben-PH
changed the title
Ben-PH
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit doesn't address dead-code warnings, as this is a WIP branch. When the branch is ready for the PR, the dead/unused code can be reviewed