-
Notifications
You must be signed in to change notification settings - Fork 899
fix(react-email): random errors because of app root selection #2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ba2158d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Meant to fix the failing
email buildin https://github.com/resend/resend/pull/7859, I've tested the preview release and can confirm it fixes the issue. Because of the way it was being configured before, it was actually type checking the user's Next app and not the preview serverSummary by cubic
Use the preview app path as the build root to stop random path resolution errors in react-email. This aligns the build with the preview server so emails load consistently.
Written for commit ba2158d. Summary will update on new commits.