fix(demo): builds failing after tailwind bump #2881
Draft
+610
−266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
gabrielmfern
force-pushed
the
fix/demo-build-fails-after-tailwind-bump
branch
from
94b0aa8 to
a5dfe9c
Compare
This reverts commit acb0b07.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of this is the most recent version bump #2878 which is failing the demo deploy exactly because of this. The issue is that, right now, we reinstall dependencies for the preview server to work properly, which, since we are bumping the version of
@react-email/tailwindit's going to try installing a version that is not yet published.To fix this, this pull request adds the
apps/demo/.react-emailto the workspace so that it can have access to the workspace dependencies. This also has the upside of making things faster, at the cost of making things more interconnected and complicated. Ideally we wouldn't install at all, and just reuse the installed dependencies, but with everything I've tried in #2239, I wasn't able to get it reliably working yet.Hopefully we won't have this for very long and soon get rid of this hack. Also I think it's important to note users should never ever have to do anything like this, it's just something that's "useful" to us since we are building everything from our own repo, not installing from npm
For testing this locally, I just bumped the version for @react-email/tailwind one patch above, and tried building. Before this pull request it would fail, and now I can confirm it doesn't.