wifi_ctrl_webconfig: fix null pointer dereference in webconfig_steering_config_apply #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_config_apply The webconfig_steering_config_apply function was dereferencing the data parameter before checking if it was NULL, which could lead to segmentation faults. This commit adds a null check at the beginning of the function and returns RETURN_ERR if the pointer is NULL. Changes: - Add null check for data parameter at function start - Return RETURN_ERR with error logging if NULL - Remove redundant null check in cleanup section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
webconfig_steering_config_applyfunction insource/core/wifi_ctrl_webconfig.cto add null check for the data parameter at the beginning of the function and return early to avoid segfaults.Changes Made
dataparameter at function startTesting