wifi_ctrl_wifiapi_handlers: fix null pointer dereference in wifiapi_handle_get_ApAssocDeviceDiagnosticResult #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle_get_ApAssocDeviceDiagnosticResult The wifiapi_handle_get_ApAssocDeviceDiagnosticResult function was dereferencing dev_array before checking if it was NULL, which could lead to segmentation faults. This commit adds a null check after allocation and returns early with an error message if the pointer is NULL. Pattern: null_check_before_dereference_reorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
wifiapi_handle_get_ApAssocDeviceDiagnosticResultfunction insource/core/wifi_ctrl_wifiapi_handlers.cto add null check for the dev_array variable before dereferencing it.Changes Made
dev_arrayafter allocationTesting