Skip to content

Conversation

@spietras
Copy link
Member

No description provided.

@spietras spietras requested a review from Copilot January 21, 2026 20:49
@spietras spietras self-assigned this Jan 21, 2026
@spietras spietras added the cleanup Stay fresh label Jan 21, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors code by changing several utility functions to return structured objects instead of primitives, adds new server-side utilities for handling request URLs, and fixes a form handling bug.

Changes:

  • Changed createUrl and getValidationIssue to return structured objects with named properties instead of returning primitives directly
  • Added three new server utilities: getRequestUrl, getOriginalRequestUrl, and getOriginalBaseUrl for handling request URL transformations
  • Fixed form handling by replacing setValues with setInitialValues in the useForm hook

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/src/server/orpc/vars/procedures/vars/test/vars/validate/main.ts Refactored API response destructuring for better readability
src/src/server/generic/lib/get-request-url/* Added new utility to retrieve request URL from headers or Request object
src/src/server/generic/lib/get-original-request-url/* Added utility to reconstruct original request URL from proxy headers
src/src/server/generic/lib/get-original-base-url/* Added utility to extract base URL from original request
src/src/server/generic/constants.ts Added constants for custom header names
src/src/proxy.ts Added proxy function to handle Next.js request headers
src/src/isomorphic/core/hooks/use-form/main.ts Fixed form reset behavior by using setInitialValues instead of setValues
src/src/instrumentation.ts Updated to use new createUrl return structure
src/src/common/orpc/lib/get-validation-issue/* Changed return type from string to structured object
src/src/common/generic/lib/create-url/* Changed return type from string to structured object
src/src/client/test/components/test-widget/main.tsx Updated to access message property from getValidationIssue
src/src/common/localization/locales/*.po.jinja Updated line number references after code changes
src/package-lock.json.jinja Updated various package dependencies to newer versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spietras spietras merged commit c4d931f into main Jan 21, 2026
8 checks passed
@spietras spietras deleted the cleanup branch January 21, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Stay fresh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants