IPO Pulse #714
Open
IPO Pulse #714
+3,826
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reserve and don’t consume reseed budget with tier top-ups on k4 rounds - test/contract_qtf.cpp: expose private/protected internals for unit tests, add exact-match k2/k3 ticket generators (unique), fund jackpot balance in k4 test, and force FR off in baseline k2/k3 revenue-split test
…eserve top-ups; correct schedule bitmask in specx
Auto-update QTF index in QRP Adds cleanup for allowedSmartContracts in QRP
# Conflicts: # src/contract_core/contract_def.h
Contributor
Author
|
@Franziska-Mueller |
Collaborator
Franziska-Mueller
left a comment
Franziska-Mueller
left a comment
There was a problem hiding this comment.
here are some initial comments, I will continue the review tomorrow
# Conflicts: # src/Qubic.vcxproj # src/Qubic.vcxproj.filters # src/contract_core/contract_def.h # test/test.vcxproj.filters
| } | ||
|
|
||
| state.maxAutoTicketsPerUser = input.maxTicketsPerUser; | ||
| output.returnCode = toReturnCode(EReturnCode::SUCCESS); |
Collaborator
There was a problem hiding this comment.
I think there is an issue here, with the current code, the new maxAutoTicketsPerUser limit only affects new auto participants but no existing ones. When changing the maxAutoTicketsPerUser, you have to either iterate through the current auto participants and adjust their desiredTickets count accordingly or you have to add a check in ProcessAutoTickets.
| CALL(GetRandomDigits, locals.randomInput, locals.randomOutput); | ||
|
|
||
| locals.ticket.player = input.player; | ||
| locals.ticket.digits = locals.randomOutput.digits; |
Collaborator
There was a problem hiding this comment.
I think when this function is executed in the same tick (= same prev spectrum digest), it will always generate the same numbers right?
…imits and update existing entries accordingly
…er and update related logic for consistency
…ticket initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal Pulse