Skip to content

IPO QThirtyFour #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Franziska-Mueller merged 56 commits into from
Jan 26, 2026
Merged

IPO QThirtyFour #684

Franziska-Mueller merged 56 commits into from
Jan 26, 2026

Conversation

@N-010
Copy link
Contributor

@N-010 N-010 commented Dec 11, 2025 •
edited
Loading

Proposal:
QTF
QRP

N-010 added 22 commits November 8, 2025 21:44
@N-010
Implement QThirtyFour contract with ticket purchasing and winner sele…
892ec3f 
…ction logic
@N-010
Add QReservePool and QTF contract definitions with related functional…
5a6af96 
…ities
@N-010
Refactor QThirtyFour.h: reposition QTF2 struct definition for clarity
785213a
@N-010
Merge branch 'develop' into feature/2025-11-04-QThirtyFour
ff98674 
# Conflicts:
#	src/Qubic.vcxproj
#	src/contract_core/contract_def.h
@N-010
Test version for QThirtyFour
0c1e88b
@N-010
CalcReserveTopUp
28b7352
@N-010
New structs
53e4729
@N-010
Fees
ed1c941
@N-010
Refactoring
11ca689
@N-010
Remove profit transfer from k3 to k2 with FR enabled
821da1c
@N-010
Adds tests
5c4413a
@N-010
Updates testes
6c266f8
@N-010
Does not block the purchase of a ticket at a higher price
9022807
@N-010
- src/contracts/QThirtyFour.h: ensure k4 reseed uses up-to-date QRP …
095556d 
…reserve and don’t consume reseed budget with tier top-ups on k4 rounds

  - test/contract_qtf.cpp: expose private/protected internals for unit tests, add exact-match k2/k3 ticket generators (unique), fund jackpot balance in k4 test, and force FR off in baseline k2/k3 revenue-split test
@N-010
Removes SettlementLocals and aligned_storage_t
e2c9963
@N-010
Updates tests
041433c
@N-010
Update tests
e0298f8
@N-010
Update tests
c1e2829
@N-010
Merge branch 'refs/heads/develop' into feature/2025-11-04-QThirtyFour
3758979 
# Conflicts:
#	src/contract_core/contract_def.h
#	src/contracts/RandomLottery.h
#	test/test.vcxproj
#	test/test.vcxproj.filters
@N-010
Updates index
9dca2f2
@N-010
Updates inde• Fix k=4 settlement: protect jackpot reseed from k2/k3 r…
094aa9d 
…eserve top-ups; correct schedule bitmask in specx
@N-010
Fixes ContractVerify
f87354d
@N-010 N-010 marked this pull request as ready for review December 19, 2025 12:07
Franziska-Mueller
Franziska-Mueller reviewed Jan 7, 2026
View reviewed changes
N-010 added 2 commits January 8, 2026 17:50
@N-010
Adds cleanup for HashMaps
054ab67
@N-010
Renames Available to Allowed for SC
f363a9a 
Auto-update QTF index in QRP
Adds cleanup for allowedSmartContracts in QRP
Franziska-Mueller
Franziska-Mueller reviewed Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@Franziska-Mueller Franziska-Mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge develop and fix the contract indices in contract_def.h.
You can decide in which epoch the proposals for QDuel and QThirtyFour/QReservePool should happen and adapt the indices accordingly.

N-010 added 3 commits January 12, 2026 18:29
@N-010
Merge branch 'refs/heads/develop' into feature/2025-12-25-QDuel
2db5e56 
# Conflicts:
#	src/contract_core/contract_def.h
@N-010
Merge branch 'develop' into feature/2025-11-04-QThirtyFour
e6d19ad 
# Conflicts:
#	src/contract_core/contract_def.h
@N-010
Fixes comment
fde55f1
N-010 and others added 11 commits January 14, 2026 19:07
@N-010
Merge branch 'develop' into feature/2025-11-04-QThirtyFour
df816f5 
# Conflicts:
#	src/contract_core/contract_def.h
@N-010
Merge branch 'develop' into feature/2025-12-25-QDuel
fbb26c7 
# Conflicts:
#	src/contract_core/contract_def.h
@N-010
Update constructionEpoch
aa392d5
@N-010
Update constructionEpoch
41c88c6
@Franziska-Mueller
Merge branch 'develop' into feature/2025-11-04-QThirtyFour
46e094b
@N-010
Merge branch 'develop' into feature/2025-12-25-QDuel
177db71
@N-010
Fixes build and warnings
fa65169
@N-010
Merge branch 'develop' into feature/2025-11-04-QThirtyFour
4dddfc5 
# Conflicts:
#	src/Qubic.vcxproj
@N-010
Merge branch 'feature/2025-12-25-QDuel' into feature/2025-11-04-QThir…
99f7268 
…tyFour
@N-010
Fixes warnings, order
3375d24
@N-010
Merge branch 'develop' into feature/2025-11-04-QThirtyFour
705d028 
# Conflicts:
#	src/contract_core/contract_def.h
@Franziska-Mueller Franziska-Mueller merged commit 141b7d3 into qubic:develop Jan 26, 2026
2 checks passed
@philippwerner
Copy link
Contributor

philippwerner commented Jan 29, 2026

@N-010 Is everything working correctly? The following global constants may not be initialized correctly in the UEFI build:

const id QTF_ADDRESS_DEV_TEAM
const id QTF_RANDOM_LOTTERY_CONTRACT_ID
const id QTF_RESERVE_POOL_CONTRACT_ID

At least, these lines trigger the following warning: https://learn.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4210?view=msvc-170

We don't have the VCRuntime library and I have experienced at other occasions that the init does not happen in this case. I wouldn't be surprised if these are NULL_ID in the UEFI build.

Please remove these constants from the global scope in a new PR, so we get rid of this warning again.

@Franziska-Mueller I think we should extend the contact checking tool to only allow constexpr in global scope and disallow const in order to prevent this warning and potential errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Franziska-Mueller Franziska-Mueller Franziska-Mueller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@N-010 @philippwerner @Franziska-Mueller